[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7599 [Tor]: convert log() to tor_log()

#7599: convert log() to tor_log()
-------------------------+--------------------------------------------------
 Reporter:  dhill        |          Owner:                    
     Type:  enhancement  |         Status:  needs_revision    
 Priority:  normal       |      Milestone:                    
Component:  Tor          |        Version:  Tor: 0.2.4.4-alpha
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by dhill):

 Replying to [comment:1 rransom]:
 > No one is going to read that diff.  Provide a simple script to do the
 conversion instead.

 It is a straight forward diff. A quick scroll shows the only thing changed
 is log() to tor_log() and deleting the #define log.

 A script is going match log() where log() is a math function ( tor_mathlog
 do return log() ) as well as log() in comments.

 You could run:

 find . -name \*.c -print | xargs perl -pi -e 's, log\(, tor_log\(,'

 and diff it against my attached diff.  You'll have to revert it in a few
 places where I mentioned above though.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7599#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs