[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7599 [Tor]: convert log() to tor_log()

#7599: convert log() to tor_log()
-------------------------+--------------------------------------------------
 Reporter:  dhill        |          Owner:                    
     Type:  enhancement  |         Status:  needs_revision    
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor          |        Version:  Tor: 0.2.4.4-alpha
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by nickm):

  * milestone:  => Tor: 0.2.4.x-final


Comment:

 Worth doing. IMO the right time to merge this is in mid/late Dec, when I
 shouldn't have so many huge patches outstanding that will create conflicts
 here.  The approach I'll plan to take will be:
   1) Using the above technique, find all log() instances that should be
 tor_mathlog(). change them in a commit.
   2) Write a trivial script to convert
 log(LOG_{DEBUG,INFO,NOTICE,WARN,ERR} into
 log_{debug,info,notice,warn,err}(.  The script should then convert
 remaining log( into tor_log(.  Have a commit that is nothing but the
 output of the script.
   3) Make a third commit for whitespace fixes.

 Shouldn't take more than an hour. probably much less.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7599#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs