Re: [tor-bugs] #17592 [Tor]: Clean up connection timeout logic

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17592: Clean up connection timeout logic
-----------------------+------------------------------------
 Reporter:  mikeperry  |          Owner:  mikeperry
     Type:  defect     |         Status:  needs_review
 Priority:  High       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor        |        Version:
 Severity:  Normal     |     Resolution:
 Keywords:             |  Actual Points:
Parent ID:  #16861     |         Points:
  Sponsor:             |
-----------------------+------------------------------------

Comment (by teor):

 This patch looks good to me in general.

 I like the change from port 80 as the default predicted port to port 443.

 In options_validate:
 * Should we put minimum and maximum values on CircuitsAvailableTimeout,
 like the previous code for PredictedPortsRelevanceTime?

 A nitpick:

 In channelpadding_get_channel_idle_timeout:
 * I think `server_mode()` is the standard way of checking
 `options->BridgeRelay || !options->ORPort_set`. It does a few more checks,
 as far as I recall.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17592#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs