[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign

#20414: Donation banner on about:tor page for 2016 campaign
------------------------------------------------+--------------------------
 Reporter:  arthuredelstein                     |          Owner:
     Type:  defect                              |         Status:
                                                |  needs_revision
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  TorBrowserTeam201611, crowdfunding  |  Actual Points:
Parent ID:  #20413                              |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201610R, crowdfunding => TorBrowserTeam201611,
     crowdfunding
 * status:  needs_review => needs_revision


Comment:

 okay, I gave it a whirl and it looks good to me with some nits addressed:

 1) What is the scope of `count`? It seems to me we could rewrite
 {{{
     if (Services.prefs.prefHasUserValue(shownCountPref)) {
       count = Services.prefs.getIntPref(shownCountPref);
     } else {
       count = 0;
     }
 }}}
 into
 {{{
     let count = 0;
     if (Services.prefs.prefHasUserValue(shownCountPref)) {
       count = Services.prefs.getIntPref(shownCountPref);
     }
 }}}
 2) s/that stop observing/that stops observing/

 3) We put in the translations early to give translators time to produce
 the properly localized strings for non en-US Tor Browser versions. Yet the
 code is only concerned with en-US bundles anyway. What is the plan here
 then? Don't we want to ship 6.0.6 with the donation banner enabled for as
 many users as possible (this is more a needs_information point as I am not
 sure whether we should fix the code or not)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20414#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs