[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20414 [Applications/Tor Browser]: Donation banner on about:tor page for 2016 campaign
#20414: Donation banner on about:tor page for 2016 campaign
------------------------------------------------+--------------------------
Reporter: arthuredelstein | Owner:
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201611, crowdfunding | Actual Points:
Parent ID: #20413 | Points:
Reviewer: | Sponsor:
------------------------------------------------+--------------------------
Comment (by arthuredelstein):
Replying to [comment:12 gk]:
> okay, I gave it a whirl and it looks good to me with some nits
addressed:
Thanks for the review.
> 1) What is the scope of `count`?
Fixed.
> 2) s/that stop observing/that stops observing/
Fixed.
> 3) We put in the translations early to give translators time to produce
the properly localized strings for non en-US Tor Browser versions. Yet the
code is only concerned with en-US bundles anyway. What is the plan here
then? Don't we want to ship 6.0.6 with the donation banner enabled for as
many users as possible (this is more a needs_information point as I am not
sure whether we should fix the code or not)?
I have currently added several locales. I hope more can be translated in
time for the release (including French and Russian). If so, we'll need to
add those to the `kBannerLocales` list when they are ready.
New version: https://github.com/arthuredelstein/torbutton/commit/20414+11
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20414#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs