[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28611 [Core Tor/Tor]: Add `-mstack-protector-guard=global` to CFLAGS instead of `--disable-gcc-hardening` configure option on Windows?
#28611: Add `-mstack-protector-guard=global` to CFLAGS instead of `--disable-gcc-
hardening` configure option on Windows?
-------------------------------------------------+-------------------------
Reporter: grj | Owner: (none)
Type: enhancement | Status: new
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 029-backport 033-backport | Actual Points:
034-backport 035-backport win32 |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
`-mstack-protector-guard=global -fstack-
protector{,-all,-strong,-explicit}` is required on gcc 8.2 on some
targets, to work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86832
The gcc issue should be fixed in the next gcc release.
So let's combine this ticket and #27530.
If --enable-expensive-hardening is set:
* AC_TRY_RUN with tor's standard hardening flags
* if that doesn't work, use `-mstack-protector-guard=global -fstack-
protector{,-all,-strong,-explicit}`
* if that doesn't work, disable hardening
* if that doesn't work, fail configure
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28611#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs