[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9173 [Firefox Patch Issues]: Relocate RelativeLink functionality to Firefox patch
#9173: Relocate RelativeLink functionality to Firefox patch
--------------------------------------+-------------------------------
Reporter: mikeperry | Owner: mcs
Type: defect | Status: needs_information
Priority: critical | Milestone:
Component: Firefox Patch Issues | Version:
Resolution: | Keywords: tbb-usability
Actual Points: | Parent ID:
Points: |
--------------------------------------+-------------------------------
Comment (by mikeperry):
Oh, one thing was bothering me about this patch. In
nsXREDirProvider::AppendProfilePath(), you removed some initializations
that made me nervous. I think in all cases where the empty strings were
used, IsEmpty() was checked first, but I removed the code that tries to
use them anyways just to be safe:
https://gitweb.torproject.org/tor-
browser.git/commitdiff/f0519e332aa292b6b481dec6f9e6a22640157131
Let me know if you think that is a bad idea for some other reason.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9173#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs