[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9173 [Firefox Patch Issues]: Relocate RelativeLink functionality to Firefox patch

#9173: Relocate RelativeLink functionality to Firefox patch
--------------------------------------+-------------------------------
     Reporter:  mikeperry             |      Owner:  mcs
         Type:  defect                |     Status:  needs_information
     Priority:  critical              |  Milestone:
    Component:  Firefox Patch Issues  |    Version:
   Resolution:                        |   Keywords:  tbb-usability
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+-------------------------------

Comment (by brade):

 Replying to [comment:14 mikeperry]:
 > Oh, one thing was bothering me about this patch. In
 nsXREDirProvider::AppendProfilePath(), you removed some initializations
 that made me nervous. I think in all cases where the empty strings were
 used, IsEmpty() was checked first, but I removed the code that tries to
 use them anyways just to be safe:
 > https://gitweb.torproject.org/tor-
 browser.git/commitdiff/f0519e332aa292b6b481dec6f9e6a22640157131
 >
 > Let me know if you think that is a bad idea for some other reason.

 We left the lines in because the patch was smaller (which may reduce
 future conflicts when merging with future ESR releases).

 Your changes look fine, except I would initialize rv to NS_OK rather than
 an error.  If somehow the profile string was empty, the method would fail
 on the NS_ENSURE_SUCCESS line.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9173#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs