[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8614 [BridgeDB]: BridgeDB should be able to return multiple transport types at the same time
#8614: BridgeDB should be able to return multiple transport types at the same time
--------------------------+--------------------------
Reporter: asn | Owner: sysrqb
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: BridgeDB | Version:
Resolution: | Keywords: important
Actual Points: | Parent ID: #8615
Points: |
--------------------------+--------------------------
Comment (by sysrqb):
Replying to [comment:18 sysrqb]:
> > I think I'm not understanding why `minnum` is needed...wouldn't it
just be easier to only have a maximum, and then try to add
`PluggableTransport`s until either `maxnum` is reached or we can't find
any more?
> >
>
> Yes, this makes more sense, done. Originally I only had a min and we
stopped searching when we hit it, but then it seemed like a good idea to
return more if we have them, so I added in a max.
>
Hm, actually, think about this when you review
checkTransportRequirement(). If we do away with min, should we always
check `remain` unless we hit `max`?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8614#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs