Re: [tor-bugs] #1922 [Tor]: torrc.d-style configuration directories

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#1922: torrc.d-style configuration directories
-----------------------------+------------------------------
     Reporter:  aa138346     |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: unspecified
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This needs more work than I can give it, but I should say some stuff:
   * It would be a good idea to learn how to do safe string handling in C.
 strcat is just as bad as strcpy.  I do not want heap overflows in tor.
   * "/etc/tor.d" is still hardwired.
   * It still uses a fake command line.
   * It fails badly if smartlist_len(dirlist) is greater than CHAR_MAX.
 Why would you ever use a char for that?
   * concatenating files is probably not the right approach.

 These are just the basic issues; there are lots of comments and design
 discussions I made above that are still unfixed.  I think this whole thing
 needs a total rewrite.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1922#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs