[tor-bugs] #9979 [Tor]: Redundant check in channel_tls_handle_incoming

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#9979: Redundant check in channel_tls_handle_incoming
-----------------------+------------------------------------
 Reporter:  nickm      |          Owner:
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor        |        Version:
 Keywords:  tor-relay  |  Actual Points:
Parent ID:             |         Points:
-----------------------+------------------------------------
 In channel_tls_handle_incoming, we say:
 {{{
   /* If we got one, we should register it */
   if (chan) channel_register(chan);
 }}}

 But chan can never be null here.  Is this a copy-paste thing, or was there
 supposed to be some other check?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9979>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs