[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9330 [Pluggable transport]: Pluggable Transports on windows are killed with ProcessTerminate

#9330: Pluggable Transports on windows are killed with ProcessTerminate
------------------------------+--------------------------------------------
     Reporter:  yawning       |      Owner:  asn
         Type:  defect        |     Status:  new
     Priority:  normal        |  Milestone:
    Component:  Pluggable     |    Version:  Tor: unspecified
  transport                   |   Keywords:  pt, win32, pluggable transport
   Resolution:                |  Parent ID:
Actual Points:                |
       Points:                |
------------------------------+--------------------------------------------

Comment (by infinity0):

 To clarify, my suggested fix for this is to emulate a typical TERM-KILL
 loop on Unix.

 * send TERM to the process to initiate clean shutdown
 * wait a while, then see if the process has actually quit
 * send KILL to the process to force it to quit
 * wait a while, then reap [http://en.wikipedia.org/wiki/Zombie_process
 zombies]

 This is implemented in [https://gitweb.torproject.org/pluggable-
 transports/pyptlib.git/blob/HEAD:/pyptlib/util/subproc.py#l151 pyptlib's
 subproc.py].

 For windows, the counterpart (since signals are intra-process only) would
 be:

 * send CTRL-BREAK to the process to initiate clean shutdown
 * wait a while, then see if the process has actually quit
 * call ProcessTerminate to force the process to quit

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9330#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs