[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27968 [Core Tor/Tor]: SIGNAL HALT race condition in test-rebind.py

#27968: SIGNAL HALT race condition in test-rebind.py
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  ci            |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:2 catalyst]:
 > Looks good! I commented on one minor issue in the pull request.

 Thanks for the review!

 I made the errno into its symbolic constant.

 But we might see failures on some platforms, if the constant is not
 available:

     Of the following list, symbols that are not used on the current
 platform are not defined by the module. The specific list of defined
 symbols is available as errno.errorcode.keys(). Symbols available can
 include:

 https://docs.python.org/2/library/errno.html

 Also, GitHub was having storage issues when I pushed my branch:

 https://status.github.com/messages

 So I couldn't re-open a new pull request from my main account. I'll try
 again in a few hours, or tomorrow.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27968#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs