[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28127 [Core Tor/Tor]: Hidden service option HiddenServiceAuthorizeClient is incompatible with version 3

#28127: Hidden service option HiddenServiceAuthorizeClient is incompatible with
version 3
-----------------------------+------------------------------------
 Reporter:  pege             |          Owner:  neel
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, hs-auth  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by asn):

 Replying to [comment:6 dgoulet]:
 > Thanks neel.
 >
 > I'm unsure here if we should go with a flag in probably the
 `hs_service_config_t` object that we can set if we encounter a
 `HiddenServiceVersion` in the generic config process.
 >
 > This would allow us to avoid re-iterating on all the lines. What do you
 think is better?
 >

 Agreed. I think it's preferable to set a flag `hs_version_explicitly_set`
 or something instead of reiterating all the lines.

 Also, would it be possible to write a unittest about this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28127#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs