[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32220 [Applications/Tor Browser]: Change letterboxing color when dark theme is enabled

#32220: Change letterboxing color when dark theme is enabled
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can, ux-   |  Actual Points:
  team, TorBrowserTeam201910R                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by pospeselr):

 * status:  new => needs_review
 * keywords:  tbb-9.0-issues, tbb-9.0.1-can, ux-team => tbb-9.0-issues,
     tbb-9.0.1-can, ux-team, TorBrowserTeam201910R


Comment:

 Ok, I spent today working out an improved UX with letterboxing and present
 the following prototypes.

 This change gives the appearance of extending down the browser chrome to
 the content area, and the content itself being nested within it. A border
 is added that is the same color as the border currently used to separate
 the toolbars and the content area. It's currently 1px wide to match the
 rest of the chrome borders, but it can be tweaked.

 The patch to do this unfortunately does require a bit of fiddling with the
 actual fingerprinting code. The letterbox size calculation needed to be
 updated to take border width into account (and can be further tweaked to
 also take into account margin if we wish). I also discovered (and
 hopefully fixed/avoided) a neat little race condition that would result in
 over-vigorous letter-boxing when opening a new-tab.

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_32220

 == Default Theme, builtin page
 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/32220/default.png, 700px)]]

 == Default Theme, letterboxed page
 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/32220/default-letterbox.png, 700px)]]

 == Dark Theme, no letterbox
 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/32220/dark.png, 700px)]]

 == Dark Theme, letterboxed
 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/32220/dark-letterbox.png, 700px)]]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32220#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs