[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32220 [Applications/Tor Browser]: Change letterboxing color when dark theme is enabled

#32220: Change letterboxing color when dark theme is enabled
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can, ux-   |  Actual Points:
  team, TorBrowserTeam201910                     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-9.0-issues, tbb-9.0.1-can, ux-team, TorBrowserTeam201910R
     => tbb-9.0-issues, tbb-9.0.1-can, ux-team, TorBrowserTeam201910


Comment:

 I like the idea, thanks! Two things I realized while testing which should
 get fixed:

 1) Suddenly letterboxing is applied even to my default screen size which
 is properly rounded. That should not happen. Users should only see
 letterboxing in effect if the windows is a) not properly rounded on start-
 up (which is happening without your patch on my system) or b) getting
 resized.

 2) For some reason the color next to the scrollbar is still the old one on
 the `about:tor` page (that is white as before) in non-dark mode while all
 the other parts do get the chrome color. Can you see that as well on your
 system?

 It makes me a bit nervous to see the CSS changed unconditionally while
 Letterboxing itself is bound to a pref. It seems to work as far as I can
 tell but we should think harder about an upstreamable solution as I
 suspect Mozilla would not take the approach you have chosen.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32220#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs