[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16909 [Tor Browser]: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0

#16909: Adapt Tor Browser bundling to new HTTPS-Everywhere ID beginning with 5.1.0
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  gk
         Type:           |     Status:  needs_revision
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-gitian, TorBrowserTeam201509R,
  Browser                |  GeorgKoppen201509
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:11 mcs]:
 > Replying to [comment:9 gk]:
 > > bug_16909_v4 (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_16909_v4&id=ab9edec2af92418a243a8e065ce99394b4fe92d6)
 in my public tor-browser-bundle repo has a proposed fix up for review.
 >
 > This looks OK except for a couple of issues:
 > 1. Inside gitian/check-prerequisites.sh, you meant to say LTS instead of
 TLS in this error message "Your Ubuntu is too old. You need Ubuntu 14.04
 TLS or newer to build Tor Browser with Gitian."

 Arg..., thanks for finding this one. I've actually found another bug (I
 did not bump the min Ubuntu version in the README file) which I fixed as
 well in bug_16909_v5 (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_16909_v5&id=50cc584f296e3917f903d51c4e2f5fde4a49f816).

 > 2. It is unfortunate that we need to rename the HTTPS-Everywhere
 subdirectory under extensions/ within the browser profile but I do not see
 an alternative.  To ensure that the browser is reset to the version of
 HTTPS-Everywhere that we ship during an automated update, the MAR files
 are constructed so the old version is always completely removed and
 replaced with the new one. This magic happens inside make_full_update.sh
 and make_incremental_update.sh (both located under tools/update-packaging
 within the tor-browser repo). So those two programs will need to be
 patched to account for this change. Probably it is safe to always remove
 the old directory as well as the new one. Please let me know if you would
 like Kathy and I to own that part of this ticket (or open another ticket).

 This is a good point. I'll write the patch but it would be nice if
 you/Kathy could review it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16909#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs