Re: [tor-bugs] #16937 [Tor Browser]: The browser.startup.homepage pref has been translated in the Korean bundle

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16937: The browser.startup.homepage pref has been translated in the Korean bundle
-----------------------------+-----------------------------------
     Reporter:  boklm        |      Owner:  tbb-team
         Type:  defect       |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  TorBrowserTeam201509R
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by gk):

 Replying to [comment:7 brade]:
 > Replying to [comment:5 gk]:
 > > Given that a lot of our branding is in tor-browser/branding/official
 (icons for exmaple) and this is the place Mozilla has for such general,
 browser related things: what speaks against patching
 locales/browserconfig.properties to point to `about:tor` instead of
 `about:home`? This would leave all the implementation of that homepage in
 Torbutton (which is fine to me), would use the same mechanism Mozilla has
 for these things, would omit an additional file in Torbutton and, above
 all, would avoid the localization problem.
 >
 > In the past, we made an explicit decision to keep all of the components
 for the home page in Torbutton.  Separating the home page setting from the
 actual page would cause things to break if the user ever disables
 Torbutton.  (If the setting is in Torbutton and Torbutton is disabled, the
 user gets Firefox's default "about:home" page rather than a broken page.)
 > I think we should keep the setting with the implementation of about:tor
 (in Torbutton).

 Okay, that is a good argument. I am fine with that plan.

 > In regards to the spellchecker.dictionary pref values, I am OK with
 removing them, but removing them means that the spellchecker will
 automatically do red-underlining based on the built-in English dictionary
 which is less than ideal.  [Note: today the spellchecker.dictionary values
 contain underscores which Firefox doesn't handle which means no one gets
 spellchecking by default.]
 >
 > My preference is for option 3 from comment:4.  We should remove the
 entire file from Transifex and not let the localizers touch the file.  The
 spellchecker pref shouldn't blindly be set.  For example, there isn't a
 dictionary for Japanese and I suspect localizers wouldn't realize that and
 they would set it anyway.

 I totally agree that the file should be out of reach for translators I am
 just not sure how the spellcheck part should work in practise. Do we
 really want to ship en-US dictionaries to everybody just to set the
 `spellchecker.dictionary` pref to the bundle locale in order to not get
 the en-US spellchecking going? (I agree this would be suboptimal). If the
 answer is, "yes", then why? If, no, then let us omit the dictionaries (for
 non-us bundles) and don't bother with the pref.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16937#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs