[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31736 [Core Tor/Tor]: Stop using mutex_destroy(), when multiple threads can still access the mutex

#31736: Stop using mutex_destroy(), when multiple threads can still access the
mutex
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:
  consider-backport-if-needed, diagnostics,      |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression,         |
  BugSmashFund                                   |
Parent ID:  #31614                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * cc: nickm, dgoulet (added)
 * status:  new => needs_review


Comment:

 Here is a draft pull request, I'd like a quick review before continuing:
 * 0.3.5: https://github.com/torproject/tor/pull/1346

 Here are my questions:
 * Are the comments correct?
 * Have I missed any calls?
 * I skipped some calls that looked local, am I correct?

 I still need to:
 * write a changes file
 * split into multiple commits
 * check for any extra uses of these functions after 0.3.5:
   * pthread_mutex_destroy()
   * tor_mutex_uninit() - non-Windows
   * tor_mutex_free() - non-Windows
   * atomic_counter_destroy() - non-Windows, but with our atomic counter
 compat implementation

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31736#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs