[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19859 [Core Tor/Tor]: Expose stream isolation information to controllers
#19859: Expose stream isolation information to controllers
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs tor-control dns isolation | Actual Points:
needs-spec needs-design term-project |
Parent ID: | Points: 3
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Comment (by nickm):
Thanks for the patch! Before I get too deep into the code, I'll review
the spec.
It would be good if the programmer who uses this feature doesn't need to
know in advance a complete list of all the different things that can be
isolated. So for example, if we later add isolation based on source port,
or isolation based on destination address or TLD, it would be good if the
programmer doesn't need to change their code accordingly.
So what if, instead of having a bunch of different `ISOLATE_XYZ` flags, we
have one item that is a comma-separated list of `entries` flags, each
matching the name of one of the other fields?
Also, I suggest that we mark all of these fields as optional, since older
Tors will not provide them, and not all protocols necessarily have them.
Finally, the list of ClientProtocol values should mention that they can be
extended in the future.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19859#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs