[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19859 [Core Tor/Tor]: Expose stream isolation information to controllers
#19859: Expose stream isolation information to controllers
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs tor-control dns isolation | Actual Points:
needs-spec needs-design term-project |
Parent ID: | Points: 3
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_review => needs_revision
Comment:
Looking at the code, it looks plausible. I'd suggest writing unit tests
mainly for the new entry_connection_describe_status_for_controller
function. Also the argument to that function should be const. But before
you revise the code, I'd suggest doing a new version of the spec patch so
we're on the same page about the desired behavior.
Thanks for all the code; it's looking nice!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19859#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs