> On 7 Mar 2019, at 09:07, Neel Chauhan <neel@xxxxxxxxx> wrote: > > Hi teor, > > On 2019-03-05 21:12, teor wrote: >> Sure. We usually do torspec changes using GitHub pull requests. >> Can you open a pull request on https://github.com/torproject/torspec ? >> Then link to the pull request from #27491 or in an email reply. > > The GitHub PR is here: https://github.com/torproject/torspec/pull/61 Thanks, I opened a ticket to review and merge it here: https://trac.torproject.org/projects/tor/ticket/29687 It should get reviewed within a week or two. >> Here's one way we could do that: >> Add a new option ClientAutoIPv6ORPortStrategy, which takes some flags. >> When no flags are set (the default), we use the original >> ClientAutoIPv6ORPort. >> Then we add a flag for this proposal: >> - TrackFailures >> Then other tickets can use other flags: >> - CheckLocalAddresses for >> #27492 Try IPv4 or IPv6 more often based on public or private IP >> addresses >> - CheckConsensus for >> #27647 When randomly choosing IPv4 or IPv6, set IPv6 probability >> based on IPv6 weight >> What do you think? >> Would you like to make these changes to this proposal? > > These additions sound good. > > I have added the "TrackFailures" flag to my GitHub PR and also mentioned other flags will come in the future. I like what you did here: I think having one option with extra flags is better than two options. T
Attachment:
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev