[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PenguinPlay.h cleanup & much other stuff



Hi all,

I just committed the PakCompiler sources (in
penguinplay/PenguinTools/PakCompiler/). I created the PenguinTools
hierarchy for that - if anyone here doesn't like that arrangement, please
tell me as long as we can change it without much fuss.
Please note that I haven't compiled it in that environment (i.e. with the
automatically generated Makefile, available PenguinPlay.h etc) yet. Be
warned (I'll try that later this day however).

Well, while setting the Dirs up int the cvs tree I noticed some things
(again ;) :

1) We really need to do a cleanup of PenguinPlay.h, Adrian. Throwing out
the useless typedefs (e.g. int -> ppInt), making the entire thing more
readable (or perhaps dividing it into several files - ppDebug.h,
ppExceptions.h, ppTypes.h, ...) etc
I already changed the base exception class definition to the new form, but
that's just a small part.

2) What's the "src" dir exactly for? it currently only contains the
ppUtils.cc file.

3) There is no $(includedir)/PenguinPlay/ yet. IMHO PenguinPlay.h should
be the only (non-local) header that's not in $(includedir)/PenguinPlay/ ,
if at all. 

4) I changed the main Make_Common.in to the OBJS=$(COBJS) $(CXXOBJS) etc
thingy. Can you test if this actually works for your pg2d sources, Adrian?

5) We should define a set of standard exception types, e.g.:
ppEResourceAllocation   // out of memory/file not found/...
	"Allocation/Initialization/... of a resource failed"
ppEIOError   // disk full/...
	"Some IO operation failed"
ppEInvalidParameter   // null pointer/value out of range/...
	"One of the parameters has an invalid value"
ppEUnsupportedEnvironment  // perhaps better checked at compile time ??
	"This environment is not fully supported (yet). Please send the
	maintainers a note about this incident."
ppEInvalidData   // corrupt jpeg file / ...
	"The data currently processed is invalid."

6) What about having  some mailing list for automatic CVS commit
notifications? It's not necessary now, but as soon as more programming will
be dont that's a very useful thing IMHO.
(Yes, I want more mailing lists. more! More! MORE!! <drool> ;+)


Err, well, yes, that's all I think ;)

Cu
	Christian
--

God is real (unless declared as integer).