gEDA-user: Commandline option --menu-file

[Felix Ruoff <Felix@xxxxxxxxxxxxxxxxxx>]

Hello,

I found a commandline option '--menu-file' in the sources (main.c) which 
seems to be broken. (The expected functionality is given with the option 
--pcb-menu).

Do you think the same like me that this code can be removed?
I appended two patches:
0055: Removes this commandline option
0056: Removes a variable from the SettingTypePtr which seems to be unused.

Please give me some feedback, if I can check this patches in (or do it 
yourself) or if you see problems this patches introduce.

Kind regards,
Felix

From 55435ca6a6e12da07d35da2755fae2c7e7dc1556 Mon Sep 17 00:00:00 2001
From: Felix Ruoff <Felix@xxxxxxxxxxxxxxxxxx>
Date: Sun, 14 Aug 2011 17:59:53 +0200
Subject: [PATCH] Remove broken --menu-file option

The expected functionality is given by the option --pcb-menu for the GTK+ GUI
and lesstif GUI.
---
 src/global.h |    2 +-
 src/main.c   |    1 -
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/global.h b/src/global.h
index 2a5ae93..7a09d46 100644
--- a/src/global.h
+++ b/src/global.h
@@ -659,7 +659,7 @@ typedef struct			/* some resources... */
    *Groups,			/* string with layergroups */
    *Routes,			/* string with route styles */
    *FilePath, *RatPath, *RatCommand, *FontPath, *PinoutFont, *ElementPath, *LibraryPath, *Size,	/* geometry string for size */
-   *Media, *MenuFile,		/* file containing menu definitions */
+   *Media,
    *BackgroundImage,		/* PPM file for board background */
    *ScriptFilename,		/* PCB Actions script to execute on startup */
    *ActionString,		/* PCB Actions string to execute on startup */
diff --git a/src/main.c b/src/main.c
index 04b7c2f..8b51609 100644
--- a/src/main.c
+++ b/src/main.c
@@ -550,7 +550,6 @@ HID_Attribute main_attribute_list[] = {
   SSET (FontPath, PCBLIBPATH, "font-path", 0),
   SSET (ElementPath, PCBLIBPATH, "element-path", 0),
   SSET (LibraryPath, PCBLIBPATH, "lib-path", 0),
-  SSET (MenuFile, "pcb-menu.res", "menu-file", 0),
   SSET (ScriptFilename, 0, "action-script",
 	"If set, this file is executed at startup."),
   SSET (ActionString, 0, "action-string",
-- 
1.7.4.1

From 03cd882da2667416f3b5a5de4148ee4da0bf866d Mon Sep 17 00:00:00 2001
From: Felix Ruoff <Felix@xxxxxxxxxxxxxxxxxx>
Date: Sun, 14 Aug 2011 18:17:52 +0200
Subject: [PATCH] Remove unused variable

---
 src/global.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/global.h b/src/global.h
index 7a09d46..0ae5d22 100644
--- a/src/global.h
+++ b/src/global.h
@@ -659,7 +659,6 @@ typedef struct			/* some resources... */
    *Groups,			/* string with layergroups */
    *Routes,			/* string with route styles */
    *FilePath, *RatPath, *RatCommand, *FontPath, *PinoutFont, *ElementPath, *LibraryPath, *Size,	/* geometry string for size */
-   *Media,
    *BackgroundImage,		/* PPM file for board background */
    *ScriptFilename,		/* PCB Actions script to execute on startup */
    *ActionString,		/* PCB Actions string to execute on startup */
-- 
1.7.4.1


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user