Re: gEDA-user: Fixing the attribute censorship bug

[Peter Brett <peter@xxxxxxxxxxxxx>]

John Doty <jpd@xxxxxxxxx> writes:

>    On May 31, 2011, at 11:02 PM, Peter Brett wrote:

>> This script deliberately poisons the netlist.
>
> Exactly. This is consistent with other gnetlist behavior. If no
> attribute is found, the resulting value is "unknown". So, I think

Yes, and that behaviour is broken too.  If no attribute is found, no
value should be returned.  The only reason we can't do that at the
moment is that the file format doesn't support removing an attribute.

> "attribute_conflict" makes sense when there's a conflict.
>
>> In my ideal world (haha) gnetlist would generate errors on attribute
>> conflicts. :-)
>
> What kind of error do you want?

Halt netlisting and cause gnetlist to exit with a non-zero exit status.
So that the problem doesn't "get lost in all of the chatter."

>>   gnetlist -m censor_fix.scm (other gnetlist args)
>>
>> For the benefit of those who share your preference for this behaviour:
>> does loading this scm file from a configuration file work? :-)
>
> No, because it works by redefining (unique-attribute). That's defined
> in gnetlist.scm, which is loaded after the configuration files.  It
> wouldn't be hard to set up a mechanism where a configuration file
> could create a list of deferred actions, 

Let's not overload the config files with even more attack vectors for
malicious designs.  Some sort of plugin system?

                           Peter

-- 
Peter Brett <peter@xxxxxxxxxxxxx>
Remote Sensing Research Group
Surrey Space Centre



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user