Re: gEDA-user: [PATCH 0/4][PCB] Color setting updates

[Peter Tyser <ptyser@xxxxxxxxx>]

On 3/3/09, DJ Delorie <dj@xxxxxxxxxxx> wrote:
>
> Personally, I think the direction we should be going in is *to* saving
> layer color information in .pcb files.  Not sure how much of an
> argument I'd have for the non-layer colors though.

That thought crossed my mind too but I reasoned:
1. Whether the colors are stored in the PCB structure or global
settings structure, the colors fields should only be defined once. (eg
"ViaColor" should not be defined in 2 different places).

2. Functions like load_colors_from_pcb() and save_colors_to_pcb()
could be added to add the ability to load/save colors from/to a .pcb
file.  I thought this would be cleaner than having duplicate colors
defined at both the global and PCB levels.

3. It made more sense to keep the colors in the global settings
structure since many PCBs don't/won't have color information in them
and will continue to use the current color setting configuration
scheme.

4 I imagine some users might not want to inherit the colors of the
PCBs they open.

I agree that it would be nice to have the ability to store colors in a
.pcb file, but I thought that these changes would be an improvement
with or without that feature.  If others have some suggestions as far
as a cleaner implementation or about saving/loading colors in the .pcb
files I'd be happy to give it a go.

I believe the last 3 patches should apply even if the 1st one is rejected FWIW.

Thanks,
Peter


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user