On Saturday 24 October 2009 01:36:15 Peter Clifton wrote:
> On Fri, 2009-10-23 at 17:17 -0700, Jared Casper wrote:
> > > Are you sure? I think that was deleted in this commit:
> >
> > o_complex_copy() definitely still calls
> > o_complex_remove_promotable_attribs. Not sure why though.
>
> Doh.. I didn't read the diff carefully enough. One call was shown
> removed, but the diff continued on to leave the call from the function
> below (which was deleted in the commit).
>
> I'm not sure if the call is needed - I'd imagine not, but can't be 100%
> certain without having "gotten back into" libgeda.
I'm not sure either. IIRC, it *should* be a NOP, but I wasn't able to check
every code path which calls o_complex_copy() to ensure that it was.
If Jared wants to remove it, he should do that check. ;-)
Peter
--
Peter Brett <peter@xxxxxxxxxxxxx>
Remote Sensing Research Group
Surrey Space Centre
Attachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ geda-user mailing list geda-user@xxxxxxxxxxxxxx http://www.seul.org/cgi-bin/mailman/listinfo/geda-user