Re: gEDA-user: PCB: Default Saving-path

[kai-martin knaak <kmk@xxxxxxxxxxxxxxx>]

Felix Ruoff wrote:

> My name is Felix and I am studying electrical engineering in Germany.
> I am sorry for my bad English, I hope, you will understand me

No problem. You are not the only German on the list. 
In fact, we may well be the second largest user group :-)


> The following patch changes this behaviour. If a filename is given
> to this dialog, the folder-list will jump to its path. Otherwise
> there are two possibilities: If a path is given (from a previous
> run of this dialog), this path will be used, otherwise the 
> $HOME-directory of the user.

Nice. 


> diff --git a/src/hid/gtk/gui-dialog.c b/src/hid/gtk/gui-dialog.c
> 
> index ec91233..c45d970 100644
> 
> --- a/src/hid/gtk/gui-dialog.c
> 
> +++ b/src/hid/gtk/gui-dialog.c
> 
> @@ -367,7 +367,7 @@ ghid_dialog_file_select_save (gchar * title, 
gchar ** path, gchar * file,
> 
>                     gchar * shortcuts)
> 
>   {
> 
>     GtkWidget *dialog;
> 
> -  gchar *result = NULL, *folder, *seed;
> 
> +  gchar *result = NULL, *folder, *seed, *filename;

IMHO, it would be better to put the patch file in a regular attachment 
rather than copy paste it to the main body of the mail. Mail servers do 
quite a bit of space, tab and new line munging on the main body and 
render the patch unusable. By contrast, they leave attachments alone.  

An additional advice:
Go on nagging on the list until a developer either explicitly rejected 
your patch, or applied it to the source. Else, your effort will just be 
ignored like many others in the past. The official bug tracker may be 
an option. But note, that patches tend to be ignored there, too.

---<)kaimartin(>---
-- 
Kai-Martin Knaak
Öffentlicher PGP-Schlüssel:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x6C0B9F53



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user