[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: gEDA-user: unconnected tracks
Peter Clifton wrote:
> On Fri, 2011-09-16 at 02:02 +0200, Kai-Martin Knaak wrote:
>> here comes the forgotten patch for more intuitive select and
>> unselect menu items.
>
> If there are corresponding items in pcb-menu.res, it would be good to
> keep those in sync as we change gpcb-menu.res, otherwise - looks
> good.
Here comes a supplemented patch.
I also corrected a glitch: The original patch changed gpcb-menu.res
rather than gpcb-menu.res.in .
---<)kaimartin(>---
--
Kai-Martin Knaak, Email: kmk@xxxxxxxxxxxxxxx
http://pool.sks-keyservers.net:11371/pks/lookup?search=0x6C0B9F53
Still unhappy with moderation of geda-user.
Why? Because it is completely intransparent.
From 597e6ff58522e22ea1ed9629b60f4d9d1202d267 Mon Sep 17 00:00:00 2001
From: Kai-Martin Knaak <kmk@xxxxxxxxxxxx>
Date: Sat, 17 Sep 2011 00:48:37 +0200
Subject: [PATCH] More accurate description of Select() and Unselect() action
Unlike the menu and the texi manual suggest, Select(Connection) does not check
for connectivity. Instead, it acts on visible objects with the found flag set.
In addition, the select() and unselect() actions act only on objects in visible
layers. This patch changes the menu and the texi documentation accordingly.
---
doc/pcb.texi | 8 ++++----
src/action.c | 6 +++---
src/gpcb-menu.res.in | 4 ++--
src/pcb-menu.res.in | 4 ++--
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/doc/pcb.texi b/doc/pcb.texi
index d543a2c..cdf4a04 100644
--- a/doc/pcb.texi
+++ b/doc/pcb.texi
@@ -3942,9 +3942,9 @@ There are no defaults.
@itemx Select(ElementByName|ObjectByName|PadByName|PinByName)
@itemx Select(TextByName|ViaByName)
Toggles either the selection flag of the object at the cross hair position
-(@emph{ToggleObject}) or selects all visible objects, all inside a
-rectangle or all objects which have been found during the last connection
-scan. The @emph{ByName} functions use a @ref{Regular Expressions} search,
+(@emph{ToggleObject}) or selects all visible objects, all visible objects inside
+a rectangle or all objects which are visible and have the ``found'' flag set.
+The @emph{ByName} functions use a @ref{Regular Expressions} search,
always case insensitive, to select the objects.
Default:
@example
@@ -4084,7 +4084,7 @@ UnloadVendor()
@cindex unselect objects
@item Unselect(All|Block|Connection)
Unselects all visible objects, all inside a rectangle or all objects which
-have been found during the last connection scan.
+are visible and the ``found'' flag set.
Default:
@example
!Shift <Btn3Down>: Mode(Save) Mode(None) Unselect(Block)
diff --git a/src/action.c b/src/action.c
index 1923cf9..d241025 100644
--- a/src/action.c
+++ b/src/action.c
@@ -5316,13 +5316,13 @@ type specified are selected.
Selects the object under the cursor.
@item Block
-Selects all objects in a rectangle indicated by the cursor.
+Selects all visible objects in a rectangle indicated by the cursor.
@item All
-Selects all objects on the board.
+Selects all objects on visible layers.
@item Connection
-Selects all connections with the ``found'' flag set.
+Selects all visible objects with the ``found'' flag set.
@item Convert
Converts the selected objects to an element. This uses the highest
diff --git a/src/gpcb-menu.res.in b/src/gpcb-menu.res.in
index 7e63811..c69ae46 100644
--- a/src/gpcb-menu.res.in
+++ b/src/gpcb-menu.res.in
@@ -229,10 +229,10 @@ MainMenu =
#
{"Select" m=l
{"Select all visible objects" Select(All)}
- {"Select all connected objects" Select(Connection)}
+ {"Select visible found objects" Select(Connection)}
-
{"Unselect all objects" Unselect(All)}
- {"unselect all connected objects" Unselect(Connection)}
+ {"Unselect visible found objects" Unselect(Connection)}
-
{"Select by name"
{"All objects" Select(ObjectByName) active=have_regex}
diff --git a/src/pcb-menu.res.in b/src/pcb-menu.res.in
index 7e6e8bd..477edf1 100644
--- a/src/pcb-menu.res.in
+++ b/src/pcb-menu.res.in
@@ -221,10 +221,10 @@ MainMenu =
{Select
{"Select all visible objects" Select(All)}
- {"Select all connected objects" Select(Connection)}
+ {"Select visible found objects" Select(Connection)}
-
{"Unselect all objects" Unselect(All)}
- {"unselect all connected objects" Unselect(Connection)}
+ {"Unselect visible found objects" Unselect(Connection)}
-
{"Select by name" foreground=grey50 sensitive=false}
{"All objects" Select(ObjectByName) active=have_regex}
--
1.7.5.4
_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user