Re: [Libevent-users] evbuffer_add_file question

[Nick Mathewson <nickm@xxxxxxxxxxxxx>]

On Thu, Feb 11, 2010 at 7:26 PM, Niels Provos <provos@xxxxxxxxx> wrote:
> On Thu, Feb 11, 2010 at 3:28 PM, David M. Irvine <DIrvine@xxxxxxxx> wrote:
>> I'm thinking of using evbuffer_add_file  since it's integration with sendfile/splice looks really attractive.  But I'm a little confused by the offset and length parameters, specifically their types:  offset is defined as an off_t and length as a size_t.    Is there a reason why both parameters shouldn't be of type off_t?  Doing so would make length compatible with st_size field of the stat struct.
>
> There is no particular reason.   We should change it to off_t.
>

Okay, done.  I've also added a tracker entry about using the
interfaces we have there more efficiently.
(https://sourceforge.net/tracker/?func=detail&aid=2951059&group_id=50884&atid=461322
)

-- 
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.