Re: [Libevent-users] ev_send_error() and friends

[Nick Mathewson <nickm@xxxxxxxxxxxxx>]

On Mon, May 24, 2010 at 8:16 PM, Felix Nawothnig
<felix.nawothnig@xxxxxxxxxxxxxx> wrote:
> Forwarding this discussion from Bug #3006553 to the ML:

For reference, that's
https://sourceforge.net/tracker/?func=detail&aid=3006553&group_id=50884&atid=461322

> If you have no objections, feel free to apply it.

Done, with minor tweaking to make it C90-compliant.

> With that issue resolved there are other problems however:
>
> 1. The reason parameter is now redundant, everywhere, at all send
> routines. You should probably always set it to NULL, both for
> semi-correctness and to save some bytes of space (it will still do the
> same thing as before if you give it a value though).
>
> That's unfortunate but unavoidable if you want to keep compatibility.

Yup; not a huge disaster.

> 2. Having a function like evhttp_send_error() with the new behaviour
> just asks people to abuse the HTTP status phrase for detailed error
> messages (in fact your documentation says that this is what it is
> for...).
>
> It should therefore be deprecated and supplemented by another function -
> I'm calling it evhttp_send_reply_html() but you might have a better
> name.
>
> That's what the second patch is.

Okay; I'm going to upload this back to the bug artifact on sourceforge
and move the artifact to the Patches tracker so we don't lose track of
it.  The first patch is IMO a bug fix, but the second patch is
definitely a new feature, and I don't want to break the feature-freeze
for 2.0.x even for probably harmless stuff.

 [...]
> P.S.: It's 2:15 AM now and although I tested my code I obviously can't
> be sure that I didn't break anything. Also when doing "make verify"
> regress always just says "FAILED" to me... But it did that even before I
> changed anything.

I've changed the behavior of "make verify" in Git so that it should be
better at displaying what test actually fails for you.  You can also
get more verbose output from older versions of Libevent by running
./test/regress manually.  Could you please add a bugtracker entry for
the unit test that's failing for you?

many thanks,
-- 
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.