Re: [Libevent-users] [PATCH] disclose TTL for negative answers

[Nick Mathewson <nickm@xxxxxxxxxxxxx>]

On Thu, Sep 1, 2011 at 10:47 AM, Leonid Evdokimov <leon@xxxxxxxxxxxx> wrote:
> On Thu, Sep 1, 2011 at 18:36, Nick Mathewson <nickm@xxxxxxxxxxxxx> wrote:
>> When you say
>> +       if ((flags & 0x020f) && (flags & 0x020f) != DNS_ERR_NOTEXIST) {
>> +               /* there was an error and it's not NXDOMAIN */
>>
>> I don't see how (flags & 0x020f) != DNS_ERR_NOTEXIST could ever be
>> false.  DNS_ERR_NOTEXIST is 3, and (flags & 0x020f) is either 0x020f
>> or 0.
>>
>> Am I missing something, or did you mean to check something else here?
>
> Hi Nick,
>
> (flags & 0x20F) is not either 0x020F or 0, it can easily be 0x200, for
> example, for truncated OK message.

Argh; for some reason I wasn't seeing the F at the end.  Merging.

Any chance of a unit test on this one?

-- 
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.