Re: pfile_basic runs successfully under NT

[Christian Reiniger <warewolf@mayn.de>]

Peter Burns wrote:

>>Good. Do you consider the stuff (the entire LibPPlay) good enough for the
>>0.1 release now?
>
>Yes. I think its about itme for a release.

Good.

>I can still think of features that I could add to PenguinSound, but I'll do that
>for the next release.

I don't even dare to think of the list of features I'd like to add to PFile
;)

>>If yes, I'll update the source package. Can you do the Win32 binary one (or
>>send me the dll - that should be the only thing needed for the package
>>aside from the headers and docs, right?)?
>
>I'll send you the dll later on.

Thanks.


I tried compiling the package here to be sure everything is OK for the
release and, well, your PP_DEBUG_BREAK macro made some problems (Warning:
statement before comma operator has no effect). I moved the 
#define ppEvilTrick into the #ifdef PP_SYS_OS_WIN32 block and now it works
fine:

#ifdef PP_SYS_OS_WIN32
#  ifndef WIN32_LEAN_AND_MEAN
#    define WIN32_LEAN_AND_MEAN
#    define STRICT
#    endif
#  include <windows.h>
#  define ppEvilTrick(FunctionName) (\
       DebugBreak (), \
       *_pp_db_lineno_loc()=__LINE__,\
       *_pp_db_file_loc()=__FILE__,\
       *_pp_db_func_loc()=PP_FUNCTION_NAME,\
       FunctionName \
   )
#else
#  define ppEvilTrick(FunctionName) (\
       *_pp_db_lineno_loc()=__LINE__,\
       *_pp_db_file_loc()=__FILE__,\
       *_pp_db_func_loc()=PP_FUNCTION_NAME,\
       FunctionName \
   )
#endif


There are however still some warnings and even errors in PSound:

../../include/PenguinPlay/Sample.h: In method `pp::internal::Sample::Sample()':
../../include/PenguinPlay/Sample.h:218: warning: member initializers for `unsigned char * pp::internal::Sample::m_data1'
../../include/PenguinPlay/Sample.h:224: warning:   and `int pp::internal::Sample::m_bits'
../../include/PenguinPlay/Sample.h:66: warning:   will be re-ordered to match declaration order

(normal gcc pickyness) and

SampleAF.cpp: In method `bool pp::internal::SampleAF::Load(const char *)':
../../include/PenguinPlay/Sample.h:226: `int pp::internal::Sample::m_frequency' is private
SampleAF.cpp:178: within this context
../../include/PenguinPlay/Sample.h:226: `int pp::internal::Sample::m_frequency' is private
SampleAF.cpp:184: within this context
../../include/PenguinPlay/Sample.h:228: `long unsigned int pp::internal::Sample::m_length' is private
SampleAF.cpp:197: within this context
../../include/PenguinPlay/Sample.h:228: `long unsigned int pp::internal::Sample::m_length' is private
SampleAF.cpp:202: within this context
../../include/PenguinPlay/Sample.h:228: `long unsigned int pp::internal::Sample::m_length' is private
SampleAF.cpp:212: within this context
../../include/PenguinPlay/Sample.h:228: `long unsigned int pp::internal::Sample::m_length' is private
SampleAF.cpp:213: within this context
../../include/PenguinPlay/Sample.h:226: `int pp::internal::Sample::m_frequency' is private
SampleAF.cpp:239: within this context
../../include/PenguinPlay/Sample.h:226: `int pp::internal::Sample::m_frequency' is private
SampleAF.cpp:240: within this context


These members should be made "protected", right?


	Christian
-- 

Troi, report to my room. Clothing optional