[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)

To: pygame-users@xxxxxxxx
Subject: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
From: "Charlie Nolan" <funnyman3595@xxxxxxxxx>
Date: Tue, 10 Jun 2008 06:04:08 -0500
Delivered-to: archiver@xxxxxxxx
Delivered-to: pygame-users-outgoing@xxxxxxxx
Delivered-to: pygame-users@xxxxxxxx
Delivery-date: Tue, 10 Jun 2008 07:04:13 -0400
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=oaGjppQbdTnc06lIEPtD26HvaQLfT6n3cYBWQ29430o=; b=ukQ40g5/rU/DNH+iMI/VvvXLrdXcjMWr93jeuXxvGxztWeLOjlkqvHPUtzj3FKxyv2 xgXtvsQfbVEp5Ggi8b8tXfLznqrMKvSITVZ4aP0Q0Kwqzh4cvSVoKdewUm9g/tIXpB3W o1pVj6uOkBkYE6gV3Pdz5zwhHHK/2eRnW0PHs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=laR0U+zpdHhhw+5VMpqQiGpQUVJ4PhNxPQZmi+MgYT4kGtQkv8VBXn0uDoJe0VnEvV mQiYUscv8WRYXolipA/rfNuHr8A2FuMzvjb2pKB6FCXx6vdS9mxSg8xsE/eXWILiOApS 0h/ImPGYQ4QAg6+QfbIZrP5dyWhCWs/zqzs0U=
In-reply-to: <64ddb72c0806100345m339516b8w67b9b21b70116ca4@xxxxxxxxxxxxxx>
References: <3b31d2ff0805220110i2ba4e09aj3597bd85e2669c09@xxxxxxxxxxxxxx> <64ddb72c0805221617v452a65f1oae2561dadd4f2e69@xxxxxxxxxxxxxx> <3b31d2ff0806100105l37e73741if3889bfb35622e29@xxxxxxxxxxxxxx> <64ddb72c0806100345m339516b8w67b9b21b70116ca4@xxxxxxxxxxxxxx>
Reply-to: pygame-users@xxxxxxxx
Sender: owner-pygame-users@xxxxxxxx

The replacement should be functionally identical to the old version,
so if you extract each to an individual function, you can just check
to see that they're equal.  chunk is both input and output.

A good set of values to test:
-1, 0, 42, 255, 256, 257, 1023, 1024, 1025, 1024 * 3, 4095, 4096, 4097

Incidentally, 1024 * 3 is a strange value to use for the default
buffer size.  It'll always get bumped to 1024 * 4 when it hits this
chunk of code.  (or dropped to 256, in the bugged code)

I'd do it myself, but given my level of C knowledge, it'd take an
inordinate amount of time.  Modifying existing code is a whole lot
easier than creating it from whole cloth.

-FM

On 6/10/08, René Dudfield <renesd@xxxxxxxxx> wrote:
> hi,
>
> thanks for the patch, sorry I haven't got around to applying it yet.
>
> Since I think the existing code works, I thought I'd just leave it for
> now - and do other 1.8.1 things.
>
> If you can give me a test function to prove your patch also works,
> then I'll add it - but otherwise I won't apply it until pygame 1.9
> since the existing code *seems* to work.
>
>
> cheers,
>
>
> On Tue, Jun 10, 2008 at 6:05 PM, Charlie Nolan <funnyman3595@xxxxxxxxx>
> wrote:
>> So is the patch ever going to get applied to SVN, or are people just
>> smiling and ignoring me?  :)
>>
>> -FunnyMan3595 (Charlie Nolan)
>>
>> On 5/22/08, René Dudfield <renesd@xxxxxxxxx> wrote:
>>> Thanks Charlie.
>>>
>>> Yeah, I hope to finish off most of the 1.8.1 things this weekend - and
>>> then do some RC releases for about a week.
>>>
>>> If you feel like doing some more patches here are the things to do ...
>>> http://www.pygame.org/wiki/todo#Open%20Issues
>>>
>>> cheers,
>>>
>>>
>>>
>>> On Thu, May 22, 2008 at 6:10 PM, Charlie Nolan <funnyman3595@xxxxxxxxx>
>>> wrote:
>>>> Hopefully this simplifies that section enough that we don't get
>>>> another mixup like the one 1222 fixed:
>>>> http://www.seul.org/viewcvs/viewcvs.cgi/trunk/src/mixer.c?root=PyGame&rev=1222&r1=1158&r2=1222
>>>>
>>>> Applies to revision 1236.
>>>>
>>>> The bug's in 1.8.0, and it does ugly things to the sound.  Might want
>>>> to get a bugfix release out soon.
>>>>
>>>> -Charlie Nolan
>>>>
>>>
>>
>

References:
- Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
  - From: Charlie Nolan
- Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
  - From: René Dudfield

Prev by Author: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
Next by Author: Re: [pygame] [PLEASE TEST]: New locking code
Previous by thread: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
Next by thread: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
Index(es):
- Author
- Thread