[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] Watch for problems building pygame.transform on non-Windows operating systems.



Hi,

The test was to ensure the conditionally compiled code in transform.c only includes the MMX/SSE optimizations for Pentium processors. It is likely transform would fail to like if there was an error in the code anyway. But this was just an added guarantee against stray pointers. The i*86 codes may be valid for 32 bit Intel processors, but what is returned for a 64 bit machine.

Lenard

René Dudfield wrote:
hi,

I just changed the transform_test.py

For me platform.machine() was returning 'i686'.  So I added that next to 'i386'.

However I wasn't sure about the meaning of the test... is that ok?

If so we should probably also add i484, and i586... or even look for i*86 ?


cheers,

On Thu, Oct 16, 2008 at 7:38 AM, René Dudfield <renesd@xxxxxxxxx> wrote:
hi,

Committed revision 1659.

Only tested on linux.

cheers,

On Thu, Oct 16, 2008 at 7:34 AM, René Dudfield <renesd@xxxxxxxxx> wrote:
... I see you're adding scale_mmx.c in the setup.py ... However I
think it needs src/scale_mmx.c ?

Maybe instead of adding the scale_mmx.c there, you could make it so
that the scale_mmx.c is added in the normal way(to Setup.in), and then
replaced with the .o by your mod?

cheers,

On Thu, Oct 16, 2008 at 7:29 AM, René Dudfield <renesd@xxxxxxxxx> wrote:
hi,

I get this error:

gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall
-Wstrict-prototypes -fPIC -D_REENTRANT -I/usr/X11R6/include
-I/usr/include/SDL -I/usr/include/python2.5 -c src/rotozoom.c -o
build/temp.linux-i686-2.5/src/rotozoom.o
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall
-Wstrict-prototypes -fPIC -D_REENTRANT -I/usr/X11R6/include
-I/usr/include/SDL -I/usr/include/python2.5 -c src/scale2x.c -o
build/temp.linux-i686-2.5/src/scale2x.o
gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall
-Wstrict-prototypes -fPIC -D_REENTRANT -I/usr/X11R6/include
-I/usr/include/SDL -I/usr/include/python2.5 -c scale_mmx.c -o
build/temp.linux-i686-2.5/scale_mmx.o
gcc: scale_mmx.c: No such file or directory
gcc: no input files
error: command 'gcc' failed with exit status 1


On Thu, Oct 16, 2008 at 7:13 AM, Lenard Lindstrom <len-l@xxxxxxxxx> wrote:
Hi everyone,

I have just changed how pygame.transform is built (SVN rev. 1658). I can
only test this with Windows. So if anyone has problems with Linux or OS X
let me know and I will try and fix it or back out the changes.

Lenard

--
Lenard Lindstrom
<len-l@xxxxxxxxx>




--
Lenard Lindstrom
<len-l@xxxxxxxxx>