[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] Updates to distutils building



Nice one.

One big patch would be good :)

On 9/2/07, Lenard Lindstrom <len-l@xxxxxxxxx> wrote:
> I have made some Windows upgrades to setup.py and related scripts.
> Originally I set out to just get Pygame to compile under MSYS. This
> involved two changes to config_msys.py and config.py: replacing os.popen
> with subprocess.Popen so that shell scripts would run, and fixing calls
> to raw_input so the prompt would display on the MSYS console. But I have
> gone further.
>
> The paths written to Setup in an MSYS build are now Windows paths.
> distutils does not execute commands with sh.exe.
>
> The hard coded DLL file paths in setup.py are replaced with proper
> searches done by config_msys.py and config_win.py. The paths are written
> to Setup. Now setup.py is VC/MinGW agnostic.
>
> Numeric is removed from setup.in and the various config_*.py modules. It
> is unnecessary when the Numeric header files are included with the
> Pygame code.
>
> So should I submit these changes? If so, should it be as one single
> patch, or several smaller ones? I have compiled and installed Pygame for
> Pythons 2.4 and 2.5 using MinGW. I also confirmed config_win.py found
> all the dependency directories I used. I will do some further unit testing.
>
> --
> Lenard Lindstrom
> <len-l@xxxxxxxxx>
>
>