[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: gerbv failure to parse sample gerber file (data attached)



For example, polygon primitive drawing is not done in GDK.
When I tried to look at the code to add it, I noticed polygon WAS
handled in one place but not in another. In amacro it prints as circle
(and none of amacros handle p2/p3/p4/p5 parameters), but from prim(21?
i think, not in front of code now) it was properly drawn.

Adding in p2/p3 support for amacro isn't too hard, but theres also
some duplicated/senseless code in GDK version that doesnt follow
cairo's version style.

like gerbv_gdk_draw_circle() vs gdk_draw_primXX functions.
I would have never noticed until i tried going through the testsuite
gerbers and comparing output and then going wtf!



On Sun, Dec 20, 2009 at 10:08 PM, Peter Clifton <pcjc2@xxxxxxxxx> wrote:
> On Fri, 2009-12-18 at 14:39 -0500, Julian wrote:
>>        And, to answer your question about the GDK rendering, it's
>>    probably never going to get better than it is now.  Cairo is just a
>>    much more powerful library, and doing everything in GDK would require
>>    a lot of tedious coding.  Once the speed with cairo is acceptable for
>>    most users, then we'll eventually drop the GDK rendering completely.
>>    Cheers--
>
> A neat feature to add here, would be a check for whether the GDK
> rendering encounters any primitives in the gerber file which are known
> to be incorrectly drawn.
>
> You could either disable the GDK options from the rendering menu, or
> print a big fat red warning on top of the viewer window (when in GDK
> modes), so the user knows there may be trouble.
>
> Best wishes,
>
> Peter C.
>
>
>
> _______________________________________________
> geda-user mailing list
> geda-user@xxxxxxxxxxxxxx
> http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
>


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user