Re: gEDA-user: attribute promotion query

[Peter Clifton <pcjc2@xxxxxxxxx>]

On Mon, 2008-02-18 at 23:56 -0500, Ales Hvezda wrote:
> [snip]
> > > and gnetlist.  If you have a mismatch between what is configured for
> > > the attribute promotion for gschem vs gnetlist, you will get some
> > > rather incorrect netlists.
> > 
> > Hmm.. I thought it wouldn't affect gnetlist, since promotion isn't
> > enabled with reading in saved schematic files.
> 
> The attribution promotion code does have some affect when
> loading up files.  I know this cause I fixed a bug #1748143 with
> 72c4db8aa20c22baa4243a0d27b3bb3f32f3ef64 which was due to the
> "other" programs not having/not knowing about the default values for
> attribute-promotion, promote-invisible, and keep-invisible.

Ah right,

Actually, I think its only the attribute-promotion and keep-invisible
ones at work here. The comment text would suggest promote-invisible is
relevant too.

On schematic load, this code is executed if attribute-promotion is on:

(For each prim object, "tmp"):

         if (toplevel->keep_invisible == TRUE) {
            /* if we are not promoting invisible attribs, keep them */
            /* around */
            tmp->visibility = INVISIBLE;
          } else {
            /* else do the default behavior of deleting the original */
            /* object */
            s_delete(toplevel, tmp);
          }


The majority of the promotion code does look to be skipped at schematic
load time though.

I don't claim to fully grok the above logic.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user