Re: gEDA-user: let's play "guess the netlist" with gsch2pcb!

[Peter Clifton <pcjc2@xxxxxxxxx>]

On Wed, 2010-02-17 at 22:56 +0000, Peter TB Brett wrote:
> On Wednesday 17 February 2010 22:41:07 Mark Rages wrote:
> 
> > OK, I created a new user with an empty home directory.
> > test@midwesttelecine:~$ gnetlist -i -v  untitled.sch
> > gEDA/gnetlist version 1.5.2.20090328
> 
> I'm sorry Mark: I've compiled and installed 1.5.2, and I still can't reproduce 
> this issue...

Are you 100% sure you are picking up the right libgeda / gnetlist?

which gnetlist
ldd `which gnetlist`

This strikes of a bug which was fixed long ago in the 1.5.x series.

commit e869033324d7595cc11d42007109a605823e1640
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Mon Aug 17 12:01:24 2009 +0100

    gnetlist: Fix problem with attached net attribute not being honored.

    Bug tracked down and fix proposed by Robert Fitzsimons.
    
    Seems to be an artifact introduced by the change to use the new
    attrib API (b4996e267b5d9696f7e8122c40b31482ef852904).
    
    Signed-off-by: Peter Clifton <pcjc2@xxxxxxxxx>
    Tested-by: Robert Fitzsimons <robfitz@xxxxxxxx>

diff --git a/gnetlist/src/s_netattrib.c b/gnetlist/src/s_netattrib.c
index b813869..8c7d6c9 100644
--- a/gnetlist/src/s_netattrib.c
+++ b/gnetlist/src/s_netattrib.c
@@ -279,7 +279,7 @@ char *s_netattrib_net_search (OBJECT * o_current, char *want
 
     start_of_pinlist = char_ptr + 1;
     current_pin = strtok (start_of_pinlist, DELIMITERS);
-    while (current_pin && !return_value) {
+    while (current_pin) {
       if (strcmp (current_pin, wanted_pin) == 0) {
         g_free (return_value);
         return net_name;






_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user