Re: gEDA-user: Please test new grids for GTK PCB

[Felix Ruoff <Felix@xxxxxxxxxxxxxxxxxx>]

Am 24.02.2011 08:17, schrieb jpka:
> I prepare patch for new grid management, if you're interested please test it:
> https://bugs.launchpad.net/pcb/+bug/724154
> Thanks
Hi,

I have had a short test of your powerfull patch. I am not sure, if I 
shoud post my comments to the bug or the mailing list - I chose the list.

Some comments (most of them for usability):
- You often mention in the tooltips the shortcut '^M'. At my system this 
should be 'Ctrl+M'. I didn't know, that '^' is a short-cut for the 
Control key.
- At the menu-item 'Realign Grid by Mark' the <b>..</b> does not work. 
The '<b>' and '</b>' is printed as text.
- You introduces accelerators for 'Zoom In 20%' and '.. OUT .. '. The 
keyname for plus and minus on the numpad are 'KP_Add' and 'KP_Substract' 
(see: http://git.gnome.org/browse/gtk+/plain/gdk/gdkkeysyms.h). I would 
suggest to use the 'normal' plus and minus-signs because: a) I don't 
have a keypad on my laptop, b) In the menu there is no distinguish 
between the signs on the keypad and the normal buttons (at the right of 
the menu-item is printed: 'Ctrl++' and 'Ctrl+-'). The Keynames for + and 
- are 'plus' and 'minus'. (If the patch of LP:699493 will be applied, 
you also can use '+' and '-' in the gpcb-menu.res file.)
- You are modifying the file 'src/hid/common/hidlist.h' with your patch. 
For this reason, the patch did not apply to my newly checked out 
repository. This file is not avaiable if you have just cloned git. I 
think, it will be created by autogen.sh or configure, I don't know.
- Is there a possibility to draw the dots of the grid, that are aligned 
with the dots of the next grid in the colors of the next grid or a bit 
larger?
- The new default grid colors are difficult to see on my displays. I 
would suggest to use other colours by default.

I have not had a complete code review. But since now, everything works 
like expected. Thank you for your work!

Kind regards, Felix


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user