[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: [PATCH 1/2] gnetlist: Add access to all attributes from components with multiple symbol instances.

On Jan 4, 2011, at 10:45 AM, Kai-Martin Knaak wrote:

> Patrick Bernaud wrote:
>> This commit introduces 'gnetlist:get-all-package-attributes' to
>> retrieve every first attribute value for package consisting of
>> multiple symbol instances.
> So this resolves one of the more annoying warts with multiple symbol
> components. :-) 
> However, a less severe wart remains: In case of multiple values for the
> same attribute, the output still depends on the order the symbols were
> added to the schematics. This may lead to unexpected, seemingly 
> unreproducible results. 

Yes. This patch got pretty thoroughly mangled in the review and revision process. The original that Bas and I came up with yielded either the unique attribute, or "attribute_conflict". I think that's better behavior, but Patrick has other ideas. At least the "resolver" machinery here is accessible, so you can create your own plug-in to repair the behavior. You could even sort the values, take the first one, as you once advocated.

John Doty              Noqsi Aerospace, Ltd.

This message contains technical discussion involving difficult issues. No personal disrespect or malice is intended. If you perceive such, your perception is simply wrong. I'm a busy person, and in my business "go along to get along" causes mission failures and sometimes kills people, so I tend to be a bit blunt.

geda-user mailing list