[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: PCB Patches: Use c99 bool instead of manual typedef.



On Sat, 2010-06-05 at 12:30 +0100, Peter Clifton wrote:

> Why are we committing bulk NOP changes like this for anyway? Because
> they exist?

Also - it would appear the changes unintentionally changed some quoted
strings (caught when attempting to rebase my branches). I'm prepared to
accept some bugs / mistakes, but really - we need to be CAREFUL with
mechanised changes like this.

@@ -940,7 +940,7 @@ FitCrosshairIntoGrid (LocationType X, LocationType
Y)
        if (ans == NO_TYPE)
          hid_action("PointCursor");
        else if (!TEST_FLAG(SELECTEDFLAG, (LineType *)ptr2))
-         hid_actionl("PointCursor","True", NULL);
+         hid_actionl("PointCursor","true", NULL);
     }
   if (Settings.Mode == LINE_MODE
       && Crosshair.AttachedLine.State != STATE_FIRST

@@ -2020,7 +2020,7 @@ lesstif_parse_arguments (int *argc, char ***argv)
            break;
          case HID_Boolean:
            o->argKind = XrmoptionNoArg;
-           o->value = "True";
+           o->value = "true";
            acount++;
            break;
          default:





-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user