On Fri, 2008-05-02 at 15:27 +0000, Kai-Martin Knaak wrote:
> On Fri, 02 May 2008 05:18:47 +0100, Peter Clifton wrote:
>
> > Should all be fixed now ("git fetch")
>
> Hmm. I did "git fetch" in the pcjc2 dir, then "make clean" and "make
> install". However, mirrored circles are still funny and the redraw
> problem persists. Any chance, the patches did not enter the git
> repository? Can you give a specific line where a change should be present?
Hmm, you might need to re- "git checkout origin/cairo_experiment", as
the fetch probably won't have updated your working checkout.
To check, the latest commit is:
commit 4384fffb6a47cf90a82e7268cff697cd3ada13fc
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date: Fri May 2 14:15:35 2008 +0100
Fix cr and backingstore for the preview widget
(see with "git log")
The arc fix was made in an earlier commit in the patch series, but if
you look in gschem/src/o_arc.c, you will see around line 199,
if (angle1 > angle1 + angle2) {
cairo_arc (cr, x + 0.5, y + 0.5, radius, -angle1 * (M_PI / 180.),
(-angle1 - angle2) * (M_PI / 180.));
} else {
cairo_arc_negative (cr, x + 0.5, y + 0.5, radius, -angle1 * (M_PI / 180.),
(-angle1 - angle2) * (M_PI / 180.));
}
(Previously there was no if () ... and the call was cairo_arc_negative).
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user