[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] Patch to compile with MSVC7.1, bug fix to set_blocked(), adds event range-checking



Patch has been applied.
http://pygame.motherhamster.org/bugzilla/show_bug.cgi?id=2

thanks John!

On Oct 14, 2007 9:23 PM, John Popplewell <john@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> just did a check-out and had trouble compiling with the Microsoft Visual
> C++ Toolkit 2003 compiler (version 7.1).
>
> Mainly variables not declared at the top of a block, and a couple of
> casts in 'transform.c'.
>
> Also found a minor bug in pygame.event.set_blocked() when type is None,
> in 'event.c'.
>
> Whilst I was in there (and looking at the SDL code) I noticed that there
> is no range checking on the event values in Pygame or SDL. To prevent
> inadvertent trampling of memory, I've added some range checking code
> which raises a ValueError().
>
> Patch against latest SVN attached.
>
> Hope it's useful,
>
> regards,
> John.
> PS the reformatted code looks much better :-)
>
>