[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [pygame] Patch to compile with MSVC7.1, bug fix to set_blocked(), adds event range-checking
- To: pygame-users@xxxxxxxx
- Subject: Re: [pygame] Patch to compile with MSVC7.1, bug fix to set_blocked(), adds event range-checking
- From: "Brian Fisher" <brian@xxxxxxxxxxxxxxxxxxx>
- Date: Thu, 20 Dec 2007 23:55:57 -0800
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: pygame-users-outgoing@xxxxxxxx
- Delivered-to: pygame-users@xxxxxxxx
- Delivery-date: Fri, 21 Dec 2007 02:56:05 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=AUbs8Xm3FWjyJiiQi6NHzcyZFa99Vqy+wFAbDPHYP7o=; b=xLptCBy+xLutsqGz8Jt5B4EdGwNFZ8/Ne0u5btICTPUdoEHsDdr4J/tN6oOGdVaYnKLnJYdBrSVqCO1JC6ovB2D4PQvSVKCRvZlRe5V7J3P+dQvjRzLNAeSk3q+Zx3FkZZIyiZn6m9VGJ7kdU3Ta0JcKX9Q6fMMhxq6Rxspay+M=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=WTf8cVz7UN7633cMT/NMQ7T9LgvPp7pA9diTRvx2uyuUcpuGInDH3FSuArbZmN+Zyg+Z4RogZ5FbdeQYxpRe+f8fObUlPwgYJvFrCF7bnKJXQkx4K2/RPHmZwum8LL9h9en6ILyTDIew8rTSoM0psbvwm2xA8bb58GVjH9NmyHc=
- In-reply-to: <20071015052316.GA20557@xxxxxxxxxx>
- References: <20071015052316.GA20557@xxxxxxxxxx>
- Reply-to: pygame-users@xxxxxxxx
- Sender: owner-pygame-users@xxxxxxxx
Patch has been applied.
http://pygame.motherhamster.org/bugzilla/show_bug.cgi?id=2
thanks John!
On Oct 14, 2007 9:23 PM, John Popplewell <john@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> just did a check-out and had trouble compiling with the Microsoft Visual
> C++ Toolkit 2003 compiler (version 7.1).
>
> Mainly variables not declared at the top of a block, and a couple of
> casts in 'transform.c'.
>
> Also found a minor bug in pygame.event.set_blocked() when type is None,
> in 'event.c'.
>
> Whilst I was in there (and looking at the SDL code) I noticed that there
> is no range checking on the event values in Pygame or SDL. To prevent
> inadvertent trampling of memory, I've added some range checking code
> which raises a ValueError().
>
> Patch against latest SVN attached.
>
> Hope it's useful,
>
> regards,
> John.
> PS the reformatted code looks much better :-)
>
>