Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)

["Charlie Nolan" <funnyman3595@xxxxxxxxx>]

It's a cut-and-dry issue, folks.  The buffer size was being set to
256, regardless of what was passed in.  If you happen to have a
os/software/machine combination that can keep up with such a small
buffer, you'll be fine, otherwise, it'll be crackly.

This isn't some random bug that we're trying to track down.  We know
what the issue was.  As far as the functionality is concerned, my
change is a no-op, it's strictly for readability's sake.  Just test
that they perform the same, and that's sufficient.

-FM

On 6/10/08, Brian Fisher <brian@xxxxxxxxxxxxxxxxxxx> wrote:
> For what it's worth, I tested on both Windows XP and Vista and never
> experienced any of the problems with the short mixer buffer crackliness that
> is unique to pygame 1.8.0 - it's not just on OS thing, it's apparently
> hardware dependent.
>
> On Tue, Jun 10, 2008 at 12:51 PM, etrek <etrek@xxxxxxx> wrote:
>
>> Just a note about changing the mixer code again:
>> Remember that Lenard's 1222 revision fixed the crackling (crappy sound) on
>> WindowsXP/Vista systems.
>> Please make sure any new changes made to code involving mixer are tested
>> on
>> WindowsXP and/or Vista,
>> and not just on Linux systems. Before making them a part of any production
>> versions of Pygame.
>>
>> I appreciate the work you guys do on Pygame - I've been doing some cool
>> stuff with. Keep up the good work:)
>>
>> Thanks
>>
>>
>