[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)

To: pygame-users@xxxxxxxx
Subject: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
From: "Brian Fisher" <brian@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 10 Jun 2008 13:19:23 -0700
Delivered-to: archiver@xxxxxxxx
Delivered-to: pygame-users-outgoing@xxxxxxxx
Delivered-to: pygame-users@xxxxxxxx
Delivery-date: Tue, 10 Jun 2008 16:19:29 -0400
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:in-reply-to:mime-version:content-type:references :x-google-sender-auth; bh=Kt4cYhdaaFUr1fVYThRe0QXC0Dy9iwiNY88/cc29tpg=; b=sS7XJ5d1KE+tuB724e/TzeK1yPTwfkFc8SEJgymkC8K7O7GTmZ3L0baEaEpV9K0ZdN /YeArappee2LOio7IsLE7daywXjCxAcm3r/2d1WZSGaL+CZ9R90cxEgZzTMutv2LPER8 bdkxunhnLgodkpQpkuFG20vPBchlvAj528YEA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version :content-type:references:x-google-sender-auth; b=V8lQflolCj94ks06uSRgIdUoS4eLGGSa3xoc8XvFqyWD1BW+OS3923TLe6OYbC/IIJ R2bhkvvPSn2m9AZbloKgu/r7XHksLdzcI5ZMqIwqolMlv+LZ0VO3RaSvzRA6oNwyMasP 6DjE5HGy6Q2uK1PxihkGdH4z+4K4xEC8q08f4=
In-reply-to: <0972A4B97B1D425EA648D43E7D0E3068@Voyager>
References: <3b31d2ff0805220110i2ba4e09aj3597bd85e2669c09@xxxxxxxxxxxxxx> <64ddb72c0805221617v452a65f1oae2561dadd4f2e69@xxxxxxxxxxxxxx> <3b31d2ff0806100105l37e73741if3889bfb35622e29@xxxxxxxxxxxxxx> <64ddb72c0806100345m339516b8w67b9b21b70116ca4@xxxxxxxxxxxxxx> <0972A4B97B1D425EA648D43E7D0E3068@Voyager>
Reply-to: pygame-users@xxxxxxxx
Sender: owner-pygame-users@xxxxxxxx

For what it's worth, I tested on both Windows XP and Vista and never experienced any of the problems with the short mixer buffer crackliness that is unique to pygame 1.8.0 - it's not just on OS thing, it's apparently hardware dependent.

On Tue, Jun 10, 2008 at 12:51 PM, etrek <etrek@xxxxxxx> wrote:

Just a note about changing the mixer code again:
Remember that Lenard's 1222 revision fixed the crackling (crappy sound) on WindowsXP/Vista systems.
Please make sure any new changes made to code involving mixer are tested on WindowsXP and/or Vista,
and not just on Linux systems. Before making them a part of any production versions of Pygame.

I appreciate the work you guys do on Pygame - I've been doing some cool stuff with. Keep up the good work:)

Thanks

Follow-Ups:
- Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
  - From: Charlie Nolan

References:
- Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
  - From: Charlie Nolan
- Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
  - From: René Dudfield
- Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
  - From: etrek

Prev by Author: Re: [pygame] Automated Builds
Next by Author: Re: [pygame] [PLEASE TEST]: New locking code
Previous by thread: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
Next by thread: Re: [pygame] PATCH: Readability fix for "make chunk a power of 2" (src/mixer.c)
Index(es):
- Author
- Thread