Re: gEDA-user: Information on PCB

[Kai-Martin Knaak <kmk@xxxxxxxxxxxxxxx>]

On Wed, 21 Oct 2009 09:39:00 +0200, Bert Timmerman wrote:

> On Tue, 2009-10-20 at 23:23 -0700, Jared Casper wrote:
> > I've also seen a few patches sent to this list (mine
> > included, but others as well) go completely ignored.

This includes a patch of mine that enables action_strings and 
action_scripts with no-GUI HIDs. I need this for a bash script that 
produces pcb prints for documentation purpose and include creation of the 
new photo realistic mode, too. When asking on this list, I was referred 
to the main procedure in main.c. This procedure does indeed exit before 
action strings are executed if the command line options call for a no-GUI 
HID. 
After I moved the execution of action strings a bit up, I discovered, 
that src/hid/common/hidnogui.c also needed a bit of a tweak. With that in 
place, my printout script would work fine with actions. 

I asked how to produce a patch in a proper format and published this 
patch on the mailing list on 27 February 09. The response to this posting 
was nil.

Then I bugged this list about the patch twice in the following months and 
asked for the reasons. Response was: No time/overload. So I waited a few 
months, again. However, the patch still has not been applied.

Here it comes again:

diff --git a/src/hid/common/hidnogui.c b/src/hid/common/hidnogui.c
index 57509dc..2b625c3 100644
--- a/src/hid/common/hidnogui.c
+++ b/src/hid/common/hidnogui.c
@@ -58,7 +58,7 @@ nogui_invalidate_wh (int x, int y, int width, int 
height, int last)
 static void
 nogui_invalidate_lr (int l, int r, int t, int b, int last)
 {
-  CRASH;
+/*  CRASH; */
 }
 
 static void
diff --git a/src/main.c b/src/main.c
index a0b38f3..bdcb4c6 100644
--- a/src/main.c
+++ b/src/main.c
@@ -966,6 +966,19 @@ main (int argc, char *argv[])
       LayerStringToLayerStack (Settings.InitialLayerStack);
     }
 
+  if (Settings.ScriptFilename)
+    {
+      Message (_("Executing startup script file %s\n"),
+	       Settings.ScriptFilename);
+      hid_actionl ("ExecuteFile", Settings.ScriptFilename, NULL);
+    }
+
+  if (Settings.ActionString)
+    {
+      Message (_("Executing startup action %s\n"), 
Settings.ActionString);
+      hid_parse_actions (Settings.ActionString, 0);
+    }
+
   if (gui->printer || gui->exporter)
     {
       gui->do_export (0);
@@ -998,18 +1011,6 @@ main (int argc, char *argv[])
    */
   Settings.init_done = 0;
 
-  if (Settings.ScriptFilename)
-    {
-      Message (_("Executing startup script file %s\n"),
-	       Settings.ScriptFilename);
-      hid_actionl ("ExecuteFile", Settings.ScriptFilename, NULL);
-    }
-  if (Settings.ActionString)
-    {
-      Message (_("Executing startup action %s\n"), 
Settings.ActionString);
-      hid_parse_actions (Settings.ActionString, 0);
-    }
-
   if (Settings.init_done == 0)
     {
       Settings.init_done = 1;

---<(kaimartin)>---
-- 
Kai-Martin Knaak
Öffentlicher PGP-Schlüssel:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x6C0B9F53



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user