Re: gEDA-user: Information on PCB

[Peter Clifton <pcjc2@xxxxxxxxx>]

On Fri, 2009-10-23 at 14:51 +0000, Ineiev wrote:
> On 10/23/09, Kai-Martin Knaak <kmk@xxxxxxxxxxxxxxx> wrote:
> > diff --git a/src/main.c b/src/main.c
> > index a0b38f3..bdcb4c6 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -966,6 +966,19 @@ main (int argc, char *argv[])
> >        LayerStringToLayerStack (Settings.InitialLayerStack);
> >      }
> >
> > +  if (Settings.ScriptFilename)
> > +    {
> > +      Message (_("Executing startup script file %s\n"),
> > +	       Settings.ScriptFilename);
> > +      hid_actionl ("ExecuteFile", Settings.ScriptFilename, NULL);
> > +    }
> > +
> > +  if (Settings.ActionString)
> > +    {
> > +      Message (_("Executing startup action %s\n"),
> > Settings.ActionString);
> > +      hid_parse_actions (Settings.ActionString, 0);
> > +    }
> > +
> >    if (gui->printer || gui->exporter)
> >      {
> >        gui->do_export (0);
> > @@ -998,18 +1011,6 @@ main (int argc, char *argv[])
> >     */
> >    Settings.init_done = 0;
> >
> > -  if (Settings.ScriptFilename)
> > -    {
> > -      Message (_("Executing startup script file %s\n"),
> > -	       Settings.ScriptFilename);
> > -      hid_actionl ("ExecuteFile", Settings.ScriptFilename, NULL);
> > -    }
> > -  if (Settings.ActionString)
> > -    {
> > -      Message (_("Executing startup action %s\n"),
> > Settings.ActionString);
> > -      hid_parse_actions (Settings.ActionString, 0);
> > -    }
> > -
> >    if (Settings.init_done == 0)
> >      {
> >        Settings.init_done = 1;
> 
> Please consider removing Settings.init_done.

It wasn't added (or needed to be altered) in the patch.. so I don't
think it ought to be removed - at least not in the same patch.

A quick grep of the source-code suggests that it is related to the issue
I pointed to in my previous reply to KMK, that the GUI isn't "up" yet,
so can't be sent certain commands.

Since it is used in only one place (rather dubiously), and that place
explicitly refers to gtk_main_quit(), I suspect that it is old, possibly
broken code. Perhaps we need a gui->quit() or gui->exit() method.

Best regards,

Peter C.




_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user