Re: gEDA-user: PCB, I lost my layer colors

[Ineiev <ineiev@xxxxxxxxx>]

On 10/19/09, Kai-Martin Knaak <kmk@xxxxxxxxxxxxxxx> wrote:
> On Mon, 19 Oct 2009 20:13:40 +0100, Peter Clifton wrote:
>> Why do we need a tick box to preserve layer attributes? IMO, layer
>> attributes should _always_ be preserved.
> +1
> (unless layers attributes have to be skipped for backward compatibility)

I considered the next scenarios:

(a) load an old file (without layer attributes), save it
    so that older PCB versions could read it
    (they won't if any layer attributes are present)
(b) load a new file (with any layer attributes),
    save it adding colour attributes when they are absent
(c) load an old file, save it with colours
(d) load a new file, save it in a backward-compatible way
    (though without colours)

As it is done now, (a) and (b) are the defaults, (c) and (d) are performed
with changing the checkbutton.

Of course, all those (and many more) options can be implemented very easily
with an external script (perl, awk, sed, so on); if the control in PCB
is not desirable, I'll remove it and just write backward-incompatibly.

>> Ps. I'd rather see updates to copyright headers done as a separate
>> commit if possible. (Certainly the address updates etc..).
>> Editing dates / adding authors is fine.

Thank you; I'll correct.

>>> pcb --action-string 'SetLayerColor(0,#4f4f00)' board.pcb
>>
>> Hmm, I'd have thought the command line arguments would have been a neat
>> way of overriding the layer colours. I'm pretty easy either way though.
>>
>> I like the addition of the actions.
> I'd prefer to let command line action string override whatever is given
> in the file. This would be in line with the principle of least surprise.
> If I deliberately set a color on the command line, then I'd really like
> to see this color applied in the GUI.

The sequence is:

(1) the command-line arguments like `--layer-color-1 green' are parsed;
(2) the board is loaded, colours from attributes, when present,
    override those set during the previous step;
(3) actions provided with --action-string arguments are run.

I believe the colours settings resulting from (1)
should be thought of as the defaults that will be reloaded before
loading any new board. I'm not quite sure there should be
such fine differences, though.

Thanks,
Ineiev


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user